Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rust based vss-service. #34

Merged
merged 8 commits into from
Nov 22, 2024
Merged

Add Rust based vss-service. #34

merged 8 commits into from
Nov 22, 2024

Conversation

G8XSU
Copy link
Collaborator

@G8XSU G8XSU commented Sep 30, 2024 •
edited
Loading

Add Rust based vss-service.

  • Add Base workspace setup and rustfmt config.
  • Add Base protobuf generation for types.
  • Add Vss KVStore api.
  • Add Authorizer Api with NoopAuthorizer.
  • Add empty postgres KvStore implementation.
  • Add VssService and base service setup.
  • Add KvStoreTestSuite.

@G8XSU G8XSU requested a review from jkczyz September 30, 2024 05:21
@G8XSU G8XSU changed the title Add Base Rust vss-service. Add Rust based vss-service. Sep 30, 2024
@G8XSU
Copy link
Collaborator Author

G8XSU commented Nov 7, 2024

Rebased on top of main.

jkczyz
jkczyz reviewed Nov 8, 2024
View reviewed changes
Copy link

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK. Need to read through the tests still.

rust/api/src/kv_store.rs Outdated Show resolved Hide resolved
rust/api/src/kv_store.rs Outdated Show resolved Hide resolved
rust/api/src/lib.rs Show resolved Hide resolved
rust/api/src/error.rs Outdated Show resolved Hide resolved
rust/api/src/error.rs Outdated Show resolved Hide resolved
rust/server/src/main.rs Outdated Show resolved Hide resolved
rust/server/src/vss_service.rs Show resolved Hide resolved
rust/server/src/vss_service.rs Show resolved Hide resolved
rust/server/src/vss_service.rs Outdated Show resolved Hide resolved
rust/server/src/vss_service.rs Outdated Show resolved Hide resolved
@G8XSU G8XSU requested a review from jkczyz November 16, 2024 04:20
jkczyz
jkczyz reviewed Nov 18, 2024
View reviewed changes
Copy link

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits on the tests. Verified that they match the Java integration tests. https://github.com/lightningdevkit/vss-server/blob/main/java/app/src/test/java/org/vss/AbstractKVStoreIntegrationTest.java

rust/api/src/kv_store.rs Outdated Show resolved Hide resolved
rust/api/src/lib.rs Outdated Show resolved Hide resolved
rust/api/src/auth.rs Outdated Show resolved Hide resolved
rust/api/src/kv_store.rs Outdated Show resolved Hide resolved
rust/api/src/kv_store.rs Outdated Show resolved Hide resolved
rust/api/src/kv_store.rs Outdated Show resolved Hide resolved
rust/api/src/kv_store.rs Outdated Show resolved Hide resolved
rust/api/src/kv_store.rs Outdated Show resolved Hide resolved
@G8XSU
Copy link
Collaborator Author

G8XSU commented Nov 21, 2024

Addressed all current comments, lmk if it is good to squash or needs another round of review.

@G8XSU G8XSU requested a review from jkczyz November 21, 2024 22:55
jkczyz
jkczyz approved these changes Nov 21, 2024
View reviewed changes
Copy link

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's squash and merge.

rust/api/src/kv_store_tests.rs Outdated Show resolved Hide resolved
@G8XSU
Copy link
Collaborator Author

G8XSU commented Nov 21, 2024

Will fix and squash !

@G8XSU
Copy link
Collaborator Author

G8XSU commented Nov 22, 2024

Squashed with minor fixups, diff here: https://github.com/lightningdevkit/vss-server/compare/13496520de8a5ba61943c1bacf6c280be2c37ebb..2fc3fd3fb451e4f430e82efd98b5c84fa7dfb29e

@G8XSU G8XSU merged commit f958e1f into lightningdevkit:main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkczyz jkczyz jkczyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G8XSU @jkczyz